search

linagora / esn-frontend-common-libs

Common ground for OpenPaaS frontend (https://open-paas.org)
Other
4 stars 12 forks source link

Remove search provider dropdown #110

Closed fabienmoyon closed 4 years ago

fabienmoyon commented 4 years ago

CURRENT

Before the split, the global search was able to provide a search provider per module on the platform.

Capture d’écran de 2020-08-27 14-38-33

EXPECTED

Now each module is displayed on this own tab so we don't need anymore to be able to chosse the search provider. We can only search in to the module displayed.

Capture d’écran de 2020-08-27 14-38-52

TO DO

tuanlc commented 4 years ago

I don't think we should remove them. Search all is a nice feature.

@fabienmoyon can you explain why?

rezk2ll commented 4 years ago

I don't think we should remove them. Search all is a nice feature.

@fabienmoyon can you explain why?

I think it doesn't make any sense anymore, since the dropdown list only has 2 options All and the current SPA ( ie contact ). I think selecting all is the same as selecting the current SPA, so it kinda feels meaningless since you can't search in other SPAs/services. image

if we decide to keep it we need to provide each SPA with the list of providers that can be searched and a way to communicate with each other.