search

linagora / esn-frontend-common-libs

Common ground for OpenPaaS frontend (https://open-paas.org)
Other
4 stars 12 forks source link

Wait for token to boostrap session #227

Closed alagane closed 3 years ago

alagane commented 3 years ago

The user API need authentication. Then the first request to user API on mailto will not fail and it will load correctly.

Related to https://github.com/linagora/customers/issues/55

tanandy commented 3 years ago

please squash the pr when reviewed

tanandy commented 3 years ago

tests are failing

alagane commented 3 years ago

tests are failing

The last commit should fix tests.

rezk2ll commented 3 years ago

squash'em

alagane commented 3 years ago

squash'em

We can squash'em when merging no? I took the habit to make fixup commits so the review is easier. I do not know the best solution for this problem.

rezk2ll commented 3 years ago

squash'em

We can squash'em when merging no? I took the habit to make fixup commits so the review is easier. I do not know the best solution for this problem.

GitHub doesn't support the option to squash when merging like GitLab. for the review part when the PR is fine we can squash and to not lose approvals by committing again we can ask @tanandy to change the settings to disable the Dismiss stale pull request approvals when new commits are pushed like this:

image

alagane commented 3 years ago

squash'em

We can squash'em when merging no? I took the habit to make fixup commits so the review is easier. I do not know the best solution for this problem.

GitHub doesn't support the option to squash when merging like GitLab. for the review part when the PR is fine we can squash and to not lose approvals by committing again we can ask @tanandy to change the settings to disable the Dismiss stale pull request approvals when new commits are pushed like this:

Isn't this button ok? image

tanandy commented 3 years ago

squash'em

We can squash'em when merging no? I took the habit to make fixup commits so the review is easier. I do not know the best solution for this problem.

GitHub doesn't support the option to squash when merging like GitLab. for the review part when the PR is fine we can squash and to not lose approvals by committing again we can ask @tanandy to change the settings to disable the Dismiss stale pull request approvals when new commits are pushed like this:

Isn't this button ok? image

yes it is exactly what i mean by squash :)

rezk2ll commented 3 years ago

squash'em

We can squash'em when merging no? I took the habit to make fixup commits so the review is easier. I do not know the best solution for this problem.

GitHub doesn't support the option to squash when merging like GitLab. for the review part when the PR is fine we can squash and to not lose approvals by committing again we can ask @tanandy to change the settings to disable the Dismiss stale pull request approvals when new commits are pushed like this:

Isn't this button ok? image

oops