linagora / esn-frontend-common-libs

Common ground for OpenPaaS frontend (https://open-paas.org)
Other
4 stars 12 forks source link

#83 modify esnI18nService.translate method #89

Closed tuanlc closed 4 years ago

tuanlc commented 4 years ago

Consistent the input of esnI18nService.translate and angular translate filter, the second param (if present) is an object that contains pairs of key + value

itswillta commented 4 years ago

Can we have 2 commits with one of them just to remove the IIFEs?

piavgh commented 4 years ago

Can we have 2 commits with one of them just to remove the IIFEs?

+1 for this. It's hard to see what are the core changes.

tuanlc commented 4 years ago

I separated commits