search

linagora / esn-frontend-inbox

Webmail SPA for the OpenPaaS Suite - https://open-paas.org
Other
12 stars 19 forks source link

As an User I want to be able to insert a link in the composer #427

Closed fabienmoyon closed 2 years ago

fabienmoyon commented 3 years ago

Capture d’écran de 2021-04-22 17-25-39

in modules/linagora.esn.unifiedinbox/frontend/app/constants.js add ['link', ['link']] in INBOX_SUMMERNOTE_OPTIONS constant : 

.constant('INBOX_SUMMERNOTE_OPTIONS', {
    focus: false,
    airMode: false,
    disableResizeEditor: true,
    toolbar: [
      ['style', ['style']],
      ['color', ['color']],
      ['font', ['bold', 'italic', 'underline', 'strikethrough']],
      ['alignment', ['paragraph', 'ul', 'ol']],
      ['link', ['link']]
    ],
    keyMap: {
      pc: {'CTRL+ENTER': '', ENTER: 'insertParagraph'},
      mac: {'CMD+ENTER': '', ENTER: 'insertParagraph'}
    }
  })
chibenwa commented 3 years ago

I think "open in new window" should be true by default, and I wonder if it should not always be true in the context of an email. Why asking the user about it?

fabienmoyon commented 3 years ago

I think "open in new window" should be true by default, and I wonder if it should not always be true in the context of an email. Why asking the user about it?

Yes true, I will configure it by default

fabienmoyon commented 3 years ago

It's possible from the version v0.8.4 see https://github.com/summernote/summernote/pull/2195

We are currently using the fork version v0.8.2-1 released on 21 Sep 2016 https://github.com/linagora/summernote/releases/tag/0.8.2-1 and https://github.com/OpenPaaS-Suite/esn-frontend-common-libs/blob/main/package.json#L72 I propose to create a task to upgrade summernote to the latest versionv0.8.18` released on 20 May 2020 https://github.com/summernote/summernote/releases and to check how the version behaves in the composer (I hope this version will fix many issues met by users).

We have some others dependencies to update like https://github.com/OpenPaaS-Suite/esn-frontend-inbox/issues/431 and https://github.com/OpenPaaS-Suite/esn-frontend-common-libs/security/dependabot

chibenwa commented 3 years ago

+1 for summernote version update.

Arsnael commented 3 years ago

+1 as well, if it can solve this easily without much work