search

linagora / james-project

Mirror of Apache James Project
Apache License 2.0
70 stars 63 forks source link

[Postgres] Fix some JMAP postgres integration tests #5077

Closed hungphan227 closed 6 months ago

hungphan227 commented 6 months ago

Fix the following:

server/protocols/jmap-rfc-8621-integration-tests/postgres-jmap-rfc-8621-integration-tests/src/test/java/org/apache/james/jmap/rfc8621/postgres/PostgresEmailGetMethodTest.java

server/protocols/jmap-rfc-8621-integration-tests/postgres-jmap-rfc-8621-integration-tests/src/test/java/org/apache/james/jmap/rfc8621/postgres/PostgresEmailQueryMethodTest.java

server/protocols/jmap-rfc-8621-integration-tests/postgres-jmap-rfc-8621-integration-tests/src/test/java/org/apache/james/jmap/rfc8621/postgres/PostgresMailboxSetMethodTest.java

server/protocols/jmap-rfc-8621-integration-tests/postgres-jmap-rfc-8621-integration-tests/src/test/java/org/apache/james/jmap/rfc8621/postgres/PostgresPushSubscriptionSetMethodTest.java

server/protocols/jmap-rfc-8621-integration-tests/postgres-jmap-rfc-8621-integration-tests/src/test/java/org/apache/james/jmap/rfc8621/postgres/PostgresThreadGetTest.java

hungphan227 commented 6 months ago

pr https://github.com/apache/james-project/pull/2048

hungphan227 commented 6 months ago

Split to smaller PRs:

quantranhong1999 commented 6 months ago

(Summary in case we forgot about PRs)

We suspect the postgres-jmap-it are actually slow => increase the timeout to 1 hour for now: https://github.com/apache/james-project/pull/2114

We try to fully run the Distributed JMAP test suite to compare to the Postgres one:

If the runtime distribution between Distributed and Postgres is kinda the same, then likely the performance of the Postgres one is ok, which means we can just increase the timeout.

Arsnael commented 6 months ago

If the runtime distribution between Distributed and Postgres is kinda the same, then likely the performance of the Postgres one is ok, which means we can just increase the timeout.

Means we can probably put back the remaining disabled tests as well and considering timeout isn't an issue anymore