linagora / james-project

Mirror of Apache James Project
Apache License 2.0
70 stars 63 forks source link

User renaming: do not require old user to exist #5085

Closed chibenwa closed 6 months ago

chibenwa commented 6 months ago

Why

Might not be absolutly necessary IMO

Also the temptation is to "just" change the mail parameter of the ldap without recreating a new user (ie fixed uid)

How

Add a "force" option that bypasses the user existance check...

vttranlina commented 6 months ago

Is it a task to change James source code?

I'm confused here, Is it related to UsernameChangeTaskStep? I see we do not support updateUser in ReadOnlyLDAPUserDAO

Arsnael commented 6 months ago

Note that James has no right to alter data on ldap so far in our code.

I think it is for the user renaming task, to which usually we require that old user and new one exist to do the migration

What I think is @chibenwa saying here, the use case here would be:

Correct @chibenwa ?

vttranlina commented 6 months ago

very clear, thank you @Arsnael

vttranlina commented 6 months ago

PR https://github.com/apache/james-project/pull/2054

chibenwa commented 6 months ago

Correct @chibenwa ?

Yes correct