search

linagora / james-project

Mirror of Apache James Project
Apache License 2.0
70 stars 63 forks source link

[Postgres] Fix MailboxSetMethodContract #5133

Closed Arsnael closed 4 months ago

Arsnael commented 4 months ago

The change made here created issues in Memory and Distributed tests for MailboxSetMethodContract.webSocketShouldPushNewMessageWhenChangeSubscriptionOfMailbox https://github.com/apache/james-project/pull/2108/files#diff-ac1365541e08f69dc4e57ee445faa58e904eb86a908f3b76c359ace9b0aa376f

Need to fix it. A test should not be changed to satisfy a new implem at the detriment of others.

Arsnael commented 4 months ago

Have a look at ModularizeJmapRFC8621AuthenticationStrategyContract too, in local it breaks on my end on the postgresql branch

vttranlina commented 4 months ago

Have a look at ModularizeJmapRFC8621AuthenticationStrategyContract too, in local it breaks on my end on the postgresql branch

It passed on my local (I tried to run with mode "repeat to until failure")

image

Arsnael commented 4 months ago

Possible my intellij went a bit crazy, I keep switching branches :)

vttranlina commented 4 months ago

pr https://github.com/apache/james-project/pull/2136