search

linagora / james-project

Mirror of Apache James Project
Apache License 2.0
72 stars 62 forks source link

[Multitenant] S3 multitenancy: bucket implementation #5273

Open Arsnael opened 2 months ago

Arsnael commented 2 months ago

Implement the bucket implementation for S3 blobstore multitenancy.

Derive a bucketname per tenant within S3BlobStoreDAO when using the bucket mode.

DoD: Integration tests

vttranlina commented 2 months ago

like what PG does

Can you help me give where code logic? I checked the PGBlobStoreDAO, but don't see, even the pg table does not have a "domain" column, I miss somewhere?

Arsnael commented 2 months ago

Can you help me give where code logic?

I asked myself the same question, as you can see in that other task => https://github.com/linagora/james-project/issues/5271#issuecomment-2357784650

So I aint sure either

quantranhong1999 commented 2 months ago

Q: Theoretically we already support 1 bucket per domain, no?

Arsnael commented 2 months ago

I fail to see where in the code though, we have a bucket name column but I feel it's always default somehow. RLS is disabled on that table as well. But i might be wrong, in which case please point me to the right piece of code

quantranhong1999 commented 2 months ago

I asked for S3 implementation instead.