search

linagora / linshare-mobile-flutter-app

Mobile application for LinShare - https://linshare.org/
GNU Affero General Public License v3.0
16 stars 16 forks source link

Add APK file on GitHub release #923

Closed alagane closed 1 year ago

alagane commented 1 year ago

Description

The APK file generated by the "Release" GitHub action should also be uploaded to GitHub.

Expected result

When I am looking at https://github.com/linagora/linshare-mobile-flutter-app/releases/tag/v3.7.5 for example, I should see something like "LinShare-v3.7.5.apk" on the Assets

Current behavior

Only the sources are available. The APK file is built but it is only deployed to Google Play.

(https://github.com/linagora/linshare-mobile-flutter-app/actions/runs/4202893330/jobs/7291705555#step:9:1864)

Context

Android

hoangdat commented 1 year ago

@tk-nguyen do you have any idea for our CD?

alagane commented 1 year ago

@tk-nguyen do you have any idea for our CD?

First, add a step after "Build and deploy" to upload artifact (with version in name).

https://github.com/actions/upload-artifact

Next, I guess upload the artifact to release. I don't know if the previous step is needed to do this though.

hoangdat commented 1 year ago

Can you make a PR @alagane?

Thanks and BRs