linagora / tmail-flutter

A multi-platform (Flutter) application for reading your emails, with your favorite devices, using the JMAP protocol!
GNU Affero General Public License v3.0
324 stars 73 forks source link

No call to webfinger backend endpoint, resulting in no SSO login session #1670

Closed Arsnael closed 1 year ago

Arsnael commented 1 year ago

Description

I was testing this made by @chibenwa https://github.com/linagora/tmail-backend/pull/619 which I believed worked before cause he even made a POC video of it :)

When I tried though it didn't work. No SSO page, just the normal login one. Normally tmail-flutter asks tmail via the .webfinger/jmap endpoint for the OIDC server, then show the SSO login page if there is one.

Expected result

When trying to log in, tmail-web should call the webfinger jmap endpoint to get the SSO url, show me the SSO login screen, and redirecting to me the OIDC server when I click login

Current behavior

It does not call webfinger and shows me the normal login page. No SSO redirection to the OIDC server

Preconditions (optional)

tmail-web:master branch

Note that this was tested locally

I tested on tmail-web tags 0.7.5 and 0.7.6 and the webfinger is still called and SSO login page still showed. So the bug is very recent.

Reproduction Steps

Context

Arsnael commented 1 year ago

Somehow I can't reproduce it anymore today... Not sure what changed or if I had some unrelated issue locally yesterday... Odd :(

Feel free to close this issue

chibenwa commented 1 year ago

If anything is wrong or unstable with a wider sso use within lng we will surely catch it!

Closibg for now...