Poor network in the train take me to login page

linagora / tmail-flutter

A multi-platform (Flutter) application for reading your emails, with your favorite devices, using the JMAP protocol!

GNU Affero General Public License v3.0

301 stars 68 forks source link

Open chibenwa opened 2 months ago

chibenwa commented 2 months ago

Why do I end up in basic auth page?

This server do not offer basic auth.

How to reproduce? Take a train between Lyon and Paris.

Expectations: correct error handling.

hoangdat commented 2 months ago

Why do I end up in basic auth page?

We don't know which server have OIDC or not. Fallback of error response in web finger request is going to basic auth screen

hoangdat commented 2 months ago

chibenwa commented 2 months ago

We don't know which server have OIDC or not.

hoangdat commented 2 months ago

chibenwa commented 2 months ago

Conclusion for now:

Handle 404 on webfinger endpoint as "OIDC is not supported, fallback to basic auth"
Handle connection issue on the JMAP endpoint thus on webfinger as "Oups, network is unavailable!"

See https://github.com/linagora/tmail-flutter/issues/2966 for possible implications onto the mobile offline mode.

hoangdat commented 1 month ago

Handle connection error in #2928
Need to handle
- [ ] Handle 404 on webfinger endpoint as "OIDC is not supported, fallback to basic auth"
- [ ] Handle connection issue on the JMAP endpoint thus on webfinger as "Oups, network is unavailable!" + Retry button Message for other error?

hoangdat commented 6 days ago