search

linan7788626 / Hoopla

MIT License
1 stars 2 forks source link

Added screenshot to README #12

Closed drphilmarshall closed 8 years ago

drphilmarshall commented 8 years ago

I wanted to add a link to the JSON file that corresponds to this model, but I can't upload it into Hoopla at the moment. Some bug somewhere?

linan7788626 commented 8 years ago

Hi Phil,

If I understand you correctly , you are gonna upload a link to the JSON in the webpage of the Hoopla. (in the textbox?) But so far, we can only upload a local JSON file by clicking the button “Read in Mass Models” , the textbox is for uploading the URL of an image only.

I tried to upload a JSON model in the webpage, http://linan7788626.github.io/pages/Hoopla/index.html http://linan7788626.github.io/pages/Hoopla/index.html , and it works, but there is no ellipse shown in mass models block and source models block.

Please feel free to correct me , if I misunderstood you.

Thanks, Nan Li

—— Nan Li Postdoctoral Fellow University of Chicago & Argonne National Lab linan7788626.github.io

On Sep 14, 2016, at 11:18 PM, Phil Marshall notifications@github.com wrote:

I wanted to add a link to the JSON file that corresponds to this model, but I can't upload it into Hoopla at the moment. Some bug somewhere?

You can view, comment on, or merge this pull request online at:

https://github.com/linan7788626/Hoopla/pull/12 https://github.com/linan7788626/Hoopla/pull/12 Commit Summary

Screen shot for README Include hyperlinked screenshot in README File Changes

M README.md https://github.com/linan7788626/Hoopla/pull/12/files#diff-0 (4) A images/screenshot.png https://github.com/linan7788626/Hoopla/pull/12/files#diff-1 (0) Patch Links:

https://github.com/linan7788626/Hoopla/pull/12.patch https://github.com/linan7788626/Hoopla/pull/12.patch https://github.com/linan7788626/Hoopla/pull/12.diff https://github.com/linan7788626/Hoopla/pull/12.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/linan7788626/Hoopla/pull/12, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-DTHfD7Mc1cayAnI_Tl7OAx7Nc3tO-ks5qqMcqgaJpZM4J9e7v.

drphilmarshall commented 8 years ago

No, that's what I was trying to do too! I wonder why it didn't work for me? Anyway, great that it works for you :-)