search

linan7788626 / Hoopla

MIT License
1 stars 2 forks source link

Link to model parameters JSON #14

Closed drphilmarshall closed 8 years ago

drphilmarshall commented 8 years ago

I think this is an important feature to demo on the README page! However, for some reason this particular model file does not upload properly... Error message in js console is as follows:

eelens.js:228 Uncaught TypeError: Cannot read property 'size_px' of undefined lenswrangler.js:417 Uncaught TypeError: Cannot set property 'x' of undefined

Some problem with using the ering image?

drphilmarshall commented 8 years ago

PS. Merge this before #13, would be my advice - despite the bug...

linan7788626 commented 8 years ago

Hi Phil, just fix the bug. We need to change the format of the JSON file we want to load in as well as the format of the JSON file we save. I did modify the code for this, but I forgot to push it, sorry about it.

drphilmarshall commented 8 years ago

I thought it must be something like that! Thanks Nan :-)