All at once

[anumore]

@linan7788626

I decided to add my requests in a single issue rather than creating several of them.

Here they are:

• [ ] add delete buttons on the ellipses drawn in the upper two panels i.e for lens and source models

• [x] currently, i can add two sources in the source model but the source plane shows only one of the sources. ideally, it would help if you can enable more than one source in the lower panels. otherwise, another working solution would be to let the user have the option to choose and switch between the multiple sources.

• [x] we can save the models - that's great but there's no explanation for what can be done with the .JSON file. If I try to use it as an input for "Read in Mass models" then nothing happens.

• [ ] The model parameters in .JSON file do not tell the units and coordinate convention. One could figure out some of these things but it would be useful if this info is included in that file.

• [x] Could you please give a sample "Mass model" file somewhere so that the user knows the format?

• [ ] One can get a sense of the scale in these panels. How about adding ticks on the image borders and stating the total image size along with tick scale somewhere?

Thanks, Anu

[linan7788626]

Hi @anumore

Thanks for these comments. But if I explain the situation of some points on your list, we could make the list shorter. :-)

• [ ] add delete buttons on the ellipses drawn in the upper two panels i.e., for lens and source models

You can use the "delete" button (Mac osX) or the "backspace" button (Windows, Linux) to remove lenses and sources.

• [ ] currently, I can add two sources in the source model, but the source plane shows only one of the sources. Ideally, it would help if you can enable more than one source in the lower panels. Otherwise, another working solution would be to let the user have the option to choose and switch between the multiple sources.

Currently, we only involve one source in the app, because we do not have a good way to move multiple sources on the source plane with the current strategy of modeling the lens (from source plane to lens plane). But @drphilmarshall and I decide to update the strategy of modeling the lens (from lens plane to source plane, then back to the lens plane), which can reduce the complexity of the parameter space. So before we update the strategy, we will keep one source only.

• [ ] we can save the models - that's great, but there's no explanation for what can be done with the .JSON file. If I try to use it as an input for "Read in Mass models" then nothing happens.

If you use a .JSON file as an input for "Read in Mass models", things are occurring in the lower blocks. After uploading the .JSON file, please move the cursor in the source plane block, you will see something new, if you still can not find anything, please click on "the source plane" block to release the freezing mode. Again, these inconveniences are because of the current strategy, and they may be solved once we update the strategy

• [ ] The model parameters in .JSON file do not tell the units and coordinate convention. One could figure out some of these things but it would be useful if this info is included in that file.

This is a good point; I will add the description of the numbers in the .JSON file. Thanks.

• [ ] Could you please give a sample "Mass model" file somewhere so that the user knows the format?

We attached an example of lens models in the README below the source code: , but I agreed, we should add a link to an example of the lens model on the web page as well.

• [ ] One can get a sense of the scale in these panels. How about adding ticks on the image borders and stating the total image size along with tick scale somewhere?

I is a good idea, have you add ticks on canvas? If you could give me an instruction, I appreciate it.

Thanks, Nan

[anumore]

Hi Nan,

1. Of course, I had tried the delete button on Mac but it was not working. I checked again now and its working..strange!
2. Multiple sources: I see. Perhaps, you can just state at the bottom of that page that you may include "multiple sources" feature in the near future or something. 3 & 5. Right. I think that explanation is missing on that page. Of course, I had uploaded the .JSON file but nothing appeared on the page (upper and lower panels -- I was expecting to see contours in the upper panel for the model I saved). So, I assumed something is wrong -- either the .JSON file should not be used or something's not working. If your upgrades are going to fix this issue, then don't bother. Otherwise, it would help to have some instructions. I like the use of "tooltip". When the user brings cursor on the "Read in Mass Models" -- You could put a sentence like "See example JSON file" and hyperlink it to your example .JSON file. And, Yes - I saw that example file on gh but I thought I already tried with one JSON file which didn't seem to work, so it didn't make sense trying another one.
3. I am not familiar with javascript programming but may be you can add a layer on the canvas which has ticks on them ?? Given that your box and image sizes are fixed, there should be some way to display ticks and scales.

Thanks, Anu

[linan7788626]

Hi @anumore

Of course, I had tried the delete button on Mac but it was not working. I checked again now and its working..strange!

If you found that sometimes "delete button" did not work, it did be strange. Maybe, adding an actual button for deleting components is more sensible.

Multiple sources: I see. Perhaps, you can just state at the bottom of that page that you may include "multiple sources" feature in the near future or something. 3 & 5. Right. I think that explanation is missing on that page. Of course, I had uploaded the .JSON file but nothing appeared on the page (upper and lower panels -- I was expecting to see contours in the upper panel for the model I saved). So, I assumed something is wrong -- either the .JSON file should not be used or something's not working. If your upgrades are going to fix this issue, then don't bother. Otherwise, it would help to have some instructions. I like the use of "tooltip". When the user brings cursor on the "Read in Mass Models" -- You could put a sentence like "See example JSON file" and hyperlink it to your example .JSON file. And, Yes - I saw that example file on gh but I thought I already tried with one JSON file which didn't seem to work, so it didn't make sense trying another one.

Yes, we expect to see contours in the upper panels as soon as we upload the model, it is a problem of the synchronization between these four blocks; it will be fixed in the next big upgrade. Adding "Tooltips" is a good idea, I have added them for each button, and will push the updates when I wrap things up.

I am not familiar with javascript programming but may be you can add a layer on the canvas which has ticks on them ?? Given that your box and image sizes are fixed, there should be some way to display ticks and scales.

Thanks, I will try to add layers later. :-)

Thanks, Nan

[anumore]

@linan7788626 all sounds good. thanks!