search

linan7788626 / Hoopla

MIT License
1 stars 2 forks source link

Save image info in json #2

Closed drphilmarshall closed 8 years ago

drphilmarshall commented 8 years ago

I think the output json should completely specify the LW++ view, which means it needs to know what the image being worked on is. Can we include the image filename and/or URL in the json, so that the whole thing is loaded in?

linan7788626 commented 8 years ago

Agree, including the image file name and/or URL should be necessary. I will work on it asap.

drphilmarshall commented 8 years ago

Thanks! :-) I guess also the json filename could be related to the image name, too - if I upload he0435.png, the json I make should be he0435.json. I'm not sure if the json's should be named uniquely (to allow tracking of model evolution) but that would be a separate issue anyway :-)

On Sun, Sep 11, 2016 at 8:50 PM, Nan Li notifications@github.com wrote:

Agree, including the image file name and/or URL should be necessary. I will work on it asap.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/linan7788626/LensWranglerPlusPlus/issues/2#issuecomment-246237571, or mute the thread https://github.com/notifications/unsubscribe-auth/AArY99dBwzTrneSIsiPrW8a2Ba5bmJSRks5qpMv7gaJpZM4J5PmQ .

linan7788626 commented 8 years ago

http://lenszoo.files.wordpress.com/2013/12/asw0009cjs-zoomed.jpg

Hi Phil,

I tried to load the image above and save the URL and NAME of the image in the JSON file, it seems working. You can upload the URL in the textbox, construct your own model, then press the button "save the model" to export a JSON file named "($imageName).JSON". I also attached an example of the output JSON file below, please let me know if you have any questions or suggestions. Thanks

Nan Li

{ "name": "asw0009cjs-zoomed", "src": "http://lenszoo.files.wordpress.com/2013/12/asw0009cjs-zoomed.jpg", "components": [ { "plane": "source", "size": 1.183, "ell": 2, "ang": 22.135, "x": 0.068, "y": 0.405 }, { "plane": "lens", "theta_e": 2.077, "ell": 2, "ang": 31.842, "x": -0.54, "y": 0.811 } ] }

drphilmarshall commented 8 years ago

Looks good to me! I can't test it yet though, the example must be using code from a different branch.

linan7788626 commented 8 years ago

I just pushed the newest version to the web page of the example. I believe you can test it now. Thanks.

http://linan7788626.github.io/pages/LensWranglerPlusPlus/index.html

drphilmarshall commented 8 years ago

Excellent! I too can make a nice JSON file :-)