search

linaro-mmwg / lhg-oe-manifests

Linaro Multimedia Working Group OE repo manifests
MIT License
2 stars 9 forks source link

fix lhg-westeros-wpe build to use LinaroCDM #17

Closed psivasubramanian closed 6 years ago

psivasubramanian commented 6 years ago

Use proper LinaroCDM, instead of Metrological's CDM

psivasubramanian commented 6 years ago

@petegriffin @andrey-konovalov Kindly review

psivasubramanian commented 6 years ago

Thanks @petegriffin, I will incorporate your enhancement change. Thanks @andrey-konovalov, meta-metrological is part of overlay manifest - https://github.com/psivasubramanian/westeros_wpe_manifest/blob/master/default.xml.

andrey-konovalov commented 6 years ago

@psivasubramanian What is the reason to use an overlay manifest (which the jenkins job doesn't know about) vs having those changes directly in the lhg-oe-manifests.git, wpe/morty branch?

psivasubramanian commented 6 years ago

@petegriffin @andrey-konovalov addressed your review comments. meta-wpe & meta-metrological are the same.

petegriffin commented 6 years ago

@psivasubramanian Can you update to also include meta-metrological in the morty/wpe manifest (rather than use an overlay)? That way all we need to do is repo init, repo sync, bitbake and we should have something that works.

andrey-konovalov commented 6 years ago

@petegriffin Siva has changed his patch to bbmask meta-wpe which is already in the manifest. And according to Siva that meta-wpe is the same as the meta-metrological he uses in his overlay manifest (and indeed, the fixed revision is the same in the both places). So there is no need to change meta-wpe to meta-metrological. Unless there are other reasons to do so.

So yes, with the last version of this patch "all we need to do is repo init, repo sync, bitbake and we should have something that works".

petegriffin commented 6 years ago

@andrey-konovalov ah ok, a bit confusing the layers have different names.. but hay ho. thanks for the explanation! In which case LGTM

psivasubramanian commented 6 years ago

@petegriffin Siva has changed his patch to bbmask meta-wpe which is already in the manifest. And according to Siva that meta-wpe is the same as the meta-metrological he uses in his overlay manifest (and indeed, the fixed revision is the same in the both places). So there is no need to change meta-wpe to meta-metrological. Unless there are other reasons to do so.

So yes, with the last version of this patch "all we need to do is repo init, repo sync, bitbake and we should have something that works".

Yes, Thanks Andrey. No need for overlay manifest and sorry for the confusion.