linaro-mmwg / lhg-oe-manifests

Linaro Multimedia Working Group OE repo manifests
MIT License
2 stars 9 forks source link

manifest: remove relative symlink #24

Closed andrey-konovalov closed 4 years ago

andrey-konovalov commented 4 years ago

All along we have been using a relative symlink for setup-environment which points outside of the project path. While we've enjoyed this hack for several years, a recent change was in repo, and repo init now fails with:

error.ManifestInvalidPathError: invalid "src": ../../.repo/manifests/setup-environment: bad component: .repo

The change in repo is this one: https://gerrit.googlesource.com/git-repo/+/07392ed32662006c029299bc06617310cfe17957

The repo documentation states: The symlink is created at “dest” (relative to the top of the tree) and points to the path specified by “src” which is a path in the project.

As such, repo clearly expects that 'src' is in the project path, which is not the cause when using ../../.repo/ path.

This patch changes our folder structure in such a way that:

The main drawback is that it feels non standard to duplicate the whole manifest project again (since it's already checked out in .repo) however using .repo content also meant we were making assumptions on implementation details of repo itself.

Signed-off-by: Nicolas Dechesne nicolas.dechesne@linaro.org