search

linaro-swg / linux

Linux kernel source tree
Other
41 stars 79 forks source link

Sync OP-TEE driver with new naming of interrupts #39

Closed david-wang-2015 closed 7 years ago

david-wang-2015 commented 7 years ago

In the latest changes of optee_os, the interrupts' names are changed to "native" and "foreign" interrupts.

jenswi-linaro commented 7 years ago

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

david-wang-2015 commented 7 years ago

Fixed

jforissier commented 7 years ago 
drivers/tee/optee/rpc.c:377:7: error: 'OPTEE_SMC_RPC_FUNC_IRQ' undeclared (first use in this function)
  case OPTEE_SMC_RPC_FUNC_IRQ:
       ^~~~~~~~~~~~~~~~~~~~~~
drivers/tee/optee/rpc.c:377:7: note: each undeclared identifier is reported only once for each function it appears in
scripts/Makefile.build:293: recipe for target 'drivers/tee/optee/rpc.o' failed
make[5]: *** [drivers/tee/optee/rpc.o] Error 1

I have reverted this patch (force pushed). @davwan01 have you actually built the driver with your patch applied?

david-wang-2015 commented 7 years ago

Hi @jforissier, Is it already covered by CI? I don't know how to build and test this repository.

jforissier commented 7 years ago

So you don't know how to build linux, yet you are submitting a patch here? :confused: Anyway, it's OK, I can fix the patch myself and merge it. And, no, there is no CI in place on this repo.

jforissier commented 7 years ago

49ece5d merged.

david-wang-2015 commented 7 years ago

So you don't know how to build linux, yet you are submitting a patch here? Anyway, it's OK, I can fix the patch myself and merge it. And, no, there is no CI in place on this repo.

Hi @jforissier , Sorry, I was asked to sync up the renamed macros in this repository when I was doing the changes in optee_os (https://github.com/OP-TEE/optee_os/pull/1345). Didn't notice it's not covered by CI (at least build)... BTW, could you point me that combinations of builds/tests I should do locally before PR? Just in case I need to push some patches again. Thanks for your help. :)

jbech-linaro commented 7 years ago

@davwan01 , in your case I suspect you're using the Juno board and then I'd suggest that you try it out according to the instructions for Juno here and here.

david-wang-2015 commented 7 years ago

@jbech-linaro , OK, it seems "replace the Linux folder in Linaro release package and test again". :) Thanks.