linaro-swg / linux

Linux kernel source tree
Other
41 stars 79 forks source link

arm64: dts: hi6220: Reset the mmc hosts #43

Closed jforissier closed 7 years ago

jforissier commented 7 years ago

The MMC hosts could be left in an unconsistent or uninitialized state from the firmware. Instead of assuming, the firmware did the right things, let's reset the host controllers.

This change fixes a bug when the mmc2/sdio is initialized leading to a hung task:

[ 242.704294] INFO: task kworker/7:1:675 blocked for more than 120 seconds. [ 242.711129] Not tainted 4.9.0-rc8-00017-gcf0251f #3 [ 242.716571] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 242.724435] kworker/7:1 D 0 675 2 0x00000000 [ 242.729973] Workqueue: events_freezable mmc_rescan [ 242.734796] Call trace: [ 242.737269] [] __switch_to+0xa8/0xb4 [ 242.742437] [] __schedule+0x1c0/0x67c [ 242.747689] [] schedule+0x40/0xa0 [ 242.752594] [] schedule_timeout+0x1c4/0x35c [ 242.758366] [] wait_for_common+0xd0/0x15c [ 242.763964] [] wait_for_completion+0x28/0x34 [ 242.769825] [] mmc_wait_for_req_done+0x40/0x124 [ 242.775949] [] mmc_wait_for_req+0xc0/0xf8 [ 242.781549] [] mmc_wait_for_cmd+0x6c/0x84 [ 242.787149] [] mmc_io_rw_direct_host+0x9c/0x114 [ 242.793270] [] sdio_reset+0x34/0x7c [ 242.798347] [] mmc_rescan+0x2fc/0x360

[ ... ]

Cc: stable@vger.kernel.org Signed-off-by: Daniel Lezcano daniel.lezcano@linaro.org Signed-off-by: Wei Xu xuwei5@hisilicon.com (upstream commit 0fbdf9953b41c28845fe8d05007ff09634ee3000) Signed-off-by: Jerome Forissier jerome.forissier@linaro.org

jforissier commented 7 years ago

As the commit log says, this commit cherry-picked from upstream gets rid of annoying messages on HiKey so we might want to get it in our branch.

jenswi-linaro commented 7 years ago

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>