search

linaro-swg / linux

Linux kernel source tree
Other
41 stars 79 forks source link

Benchmark fixes #46

Closed jforissier closed 7 years ago

jforissier commented 7 years ago

A couple of minor fixes. Should I post patch number 2 ("tee: add forward declaration for struct device") to the LKML?

jbech-linaro commented 7 years ago

Looks good to me, I don't know the preference in kernel for cases like this. I.e., include vs forward declaration. Regardless that I think it's a patch that should be sent upstream. Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

jforissier commented 7 years ago

I don't know the preference in kernel for cases like this. I.e., include vs forward declaration.

There is no clear-cut answer from the source at least:

linux/include $ git grep -E "#include <linux/(platform_|)device.h>" | wc -l
195
linux/include $ git grep "struct device;" | wc -l
112

I suppose it depends on whether the .h can be useful on its own (without device.h or platform_device.h).

jenswi-linaro commented 7 years ago

Looks good to me, please post ("tee: add forward declaration for struct device") on LKML and the tee-dev list.

jforissier commented 7 years ago

Updated first commit with "Fixes:" tag, applied @jbech-linaro's R-b: and @jenswi-linaro's Acked-by:.

FYI: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-May/509790.html