search

linaro-swg / optee_examples

OP-TEE Sample Applications
Other
163 stars 140 forks source link

ta: create object_id to store the target file ID in local buffer inst… #32

Closed rdhobi closed 6 years ago

rdhobi commented 6 years ago

…ead of shared memory

The object_id in create/open/rename functions is not allowed to reside in the shared memory according to https://github.com/OP-TEE/optee_os/commit/e091b079d91b04e03ed4c465d61d63e044539b09

Fixes: https://github.com/linaro-swg/optee_examples/issues/29 Link: [1] https://github.com/OP-TEE/optee_os/commit/e091b079d91b04e03ed4c465d61d63e044539b09 Link: [2] https://github.com/OP-TEE/optee_test/commit/9811a80d

Signed-off-by: Rahul Dhobi rdhobi@slscorp.com

jforissier commented 6 years ago

Hi @rdhobi,

  1. Your subject line is too long and slightly imprecise. Please make it: "secure_storage: do not store object ID in shared memory". Also the commit text should preferably fit in lines of 75 characters (except for the tags such as Link: which are allowed to be longer), and the tags have to be all together with no blank line. Like this: 
    
secure_storage: do not store object ID in shared memory

The object_id in create/open/rename functions is not allowed to reside in the shared memory according to [1].

Fixes: https://github.com/linaro-swg/optee_examples/issues/29 Link: [1] https://github.com/OP-TEE/optee_os/commit/e091b079 Link: [2] https://github.com/OP-TEE/optee_test/commit/9811a80d Signed-off-by: Rahul Dhobi rdhobi@slscorp.com



2. `obj_id` has to be freed somewhere...
rdhobi commented 6 years ago

@jforissier : Thanks for pointing out :+1:

jforissier commented 6 years ago

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

rdhobi commented 6 years ago

@jforissier: Can you please merge this commit to master branch?

jforissier commented 6 years ago

@rdhobi sure, would you please add my Reviewed-by: and force push? Thanks.

jforissier commented 6 years ago

@rdhobi thanks, actually @igoropaniuk is the main maintainer of this project and usually merges the PRs -- Igor, I let you merge this?

igoropaniuk commented 6 years ago

@rdhobi could you please rebase on the latest master? Thanks

rdhobi commented 6 years ago

@igoropaniuk Done. Thanks!!

igoropaniuk commented 6 years ago

merged, thanks!