linaro-swg / optee_examples

OP-TEE Sample Applications
Other
163 stars 140 forks source link

Use LDFLAGS for host binaries #85

Closed ydirson closed 3 years ago

ydirson commented 3 years ago

Distributions bring their own sets of LDFLAGS, and some fail when binaries do not match their expectation after ignoring those flags.

Eg. for yocto:

ERROR: optee-examples-3.12.0+gitAUTOINC+9a755dcf4d-r0 do_package_qa: QA Issue: File /usr/bin/optee_example_secure_storage in package optee-examples doesn't have GNU_HASH (didn't pass LDFLAGS?) File /usr/bin/optee_example_acipher in package optee-examples doesn't have GNU_HASH (didn't pass LDFLAGS?) ...

Signed-off-by: Yann Dirson yann@blade-group.com

jforissier commented 3 years ago

Reviewed-by: Jerome Forissier <jerome@forissier.org>

jenswi-linaro commented 3 years ago

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

jforissier commented 3 years ago

@ydirson can you please add the review tags? Thanks.