search

linbox-team / fflas-ffpack

FFLAS-FFPACK - Finite Field Linear Algebra Subroutines / Package
http://linbox-team.github.io/fflas-ffpack/
GNU Lesser General Public License v2.1
57 stars 23 forks source link

Expect OMPFLAGS from environment #325

Closed mahrud closed 3 years ago

mahrud commented 3 years ago

I'm not sure if there's a way to set a default value for OMPFLAGS, but if that's possible, feel free to push to this branch to do that instead. I just wanted to provide one option for #309.

mahrud commented 3 years ago

Not soon. Feel free to push to my branch and excise that commit, or just make the omp flags change in a separate commit and close this PR.

On Wed, Mar 17, 2021 at 3:03 AM Clément Pernet @.***> wrote:

@ClementPernet commented on this pull request.

In fflas-ffpack/fflas/fflas_sparse/read_sparse.h https://github.com/linbox-team/fflas-ffpack/pull/325#discussion_r595787243 :

@@ -447,8 +447,8 @@ namespace FFLAS { file.write((char) &magic , sizeof(int64_t)) ; file.write((char) &field_desc, sizeof(int64_t)) ; file.write((char*) &data_type , sizeof(int64_t)) ;

  • file.write((char*) &rowdim , sizeof(int64_t)) ;
  • file.write((char*) &coldim , sizeof(int64_t)) ;
  • file.write((const char*) &rowdim , sizeof(int64_t)) ;

These edits are unrelated with this PR. Can you remove them, and possibly open another one ? Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/linbox-team/fflas-ffpack/pull/325#pullrequestreview-614009805, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYAPRSYWWSXPMF424JKFNDTEBO4RANCNFSM4WRKG6FQ .

ClementPernet commented 3 years ago

I've removed the commit and made this #332 hence I'm closing this PR.