search

linbox-team / linbox

LinBox - C++ library for exact, high-performance linear algebra
https://linbox-team.github.io/linbox
GNU Lesser General Public License v2.1
81 stars 28 forks source link

Fixing #175: RandomFFTPrime #177

Closed cyrilbouvier closed 5 years ago

cyrilbouvier commented 5 years ago

This PR fixes issue #175 I change a little the interface to RandomFFTPrime and updated the code in linbox where it was necessary. In doing so, I found a call to RandomFFTPrime that seems weird. In linbox/algorithms/matpoly-mult.h, there is four calls to generates random FFT primes less than bit and not 2^bit as I would have expected. bit is indeed a number of bits, so a small number. Do we really want prime less than bit or is it a typo ?

ClementPernet commented 5 years ago

@cyrilbouvier : this PR has been sitting here for a while. We have an unformal rule, that once a PR has been open for a while, and nobody reviewed it, it can be merged by his author if he is sure about what he's doing. This is especially true in LinBox, where we are still transitioning from the "direct push to master" to the required review " mode. I know @pascalgiorgi , assigned as a reviewer is busy and will be in the next coming weeks, and I don't feel confortable reviewing this one. So if you don't expect expert feedback on this one, please go ahead and merge it!