search

linbox-team / linbox

LinBox - C++ library for exact, high-performance linear algebra
https://linbox-team.github.io/linbox
GNU Lesser General Public License v2.1
83 stars 28 forks source link

Bashism in MPI configure check #251

Closed orlitzky closed 4 years ago

orlitzky commented 4 years ago

In https://github.com/linbox-team/linbox/blob/master/macros/mpi-check.m4#L41 there's a test,

    AS_IF([ test "x$with_mpi" == "xyes" ],

The double-equals operator is a bash-only thing, and the configure script should work in any POSIX shell. With Dash, for example, that check always produces an error. The fix is simple; just delete one of the equals signs:

    AS_IF([ test "x$with_mpi" = "xyes" ],
ClementPernet commented 4 years ago

Thanks for the report. I just pushed the trivial fix directly to master in 9e12c2d .