search

linbox-team / linbox

LinBox - C++ library for exact, high-performance linear algebra
https://linbox-team.github.io/linbox
GNU Lesser General Public License v2.1
81 stars 28 forks source link

Prob min pol #303

Closed jgdumas closed 9 months ago

jgdumas commented 1 year ago

Solves issue #301. There was indeed a bug in the random generation from seed: only values and not positions where controlled by the 'seed' variable. Also, yes minpoly is probabilistic, so the test was failing sometimes. This PR changes this to make the test only check whether the obtained polynomial is an annihilator, or just a factor of the minimal (or characteristic) polynomial.

jgdumas commented 1 year ago

Requires givaro commit > 9d6cc30 https://github.com/linbox-team/givaro/commit/9d6cc30b661b3b0383083f6cf27438c948e079c0