search

linc-technologies / ember-spreadsheet-export

Addon that encapsulates ability to render a data set as either excel or csv.
MIT License
12 stars 8 forks source link

Modernize addon #8

Closed charlesfries closed 3 years ago

charlesfries commented 3 years ago

9/13/21

Did some final cleanup today, should be good to go

pauln commented 3 years ago

Sorry for the slow response - I haven't had much time to focus on this project for a while. At first glance, this looks good thanks - I'll take a closer look and hopefully get this merged before too much longer.

charlesfries commented 3 years ago

Anything I can do to help get this merged in? I can revert some of the linting changes so it's not so grueling to review 😅

pauln commented 3 years ago

It's really just down to time, sorry - too busy to get it done during work hours, and too much else to do outside work hours... but I'll get to this soon. The linting changes aren't a problem - per my previous comment, this looks good at first glance; I just need to have a slightly deeper look and do some testing.

charlesfries commented 3 years ago

Tysm man! 🙏🙏

ncoquelet commented 3 years ago

👍

charlesfries commented 2 years ago

Would you mind doing a release when you find some time? No rush, thank you

pauln commented 2 years ago

v0.6.0 released - thanks again for your contribution @charlesfries!