Closed camposandro closed 3 months ago
Before [83224aa5] | After [25dc54f3] | Ratio | Benchmark (Parameter) |
---|---|---|---|
376 | 3.48k | 9.26 | benchmarks.mem_list |
2.61±0.5s | 2.50±0.7s | 0.96 | benchmarks.time_computation |
Click here to view all benchmarks.
Attention: Patch coverage is 63.21839%
with 32 lines
in your changes missing coverage. Please review.
Files | Coverage Δ | |
---|---|---|
src/corrgi/correlation/angular_correlation.py | 100.00% <100.00%> (ø) |
|
src/corrgi/corrgi.py | 92.30% <100.00%> (+0.64%) |
:arrow_up: |
src/corrgi/dask.py | 77.77% <80.00%> (-7.68%) |
:arrow_down: |
src/corrgi/correlation/correlation.py | 88.23% <88.23%> (ø) |
|
src/corrgi/correlation/projected_correlation.py | 0.00% <0.00%> (ø) |
|
src/corrgi/correlation/redshift_correlation.py | 0.00% <0.00%> (ø) |
Creates classes for each specific type of catalog correlation ("angular", "projected" and "redshifted"). Considering each can be used on auto and cross-correlation with or without galaxy weights, this refactoring is necessary. The goal is to have more modularity to be able to call the Fortran routines with their specific set of arguments.
Code Quality