Compute angular correlation with weights

lincc-frameworks-mask-incubator / corrgi

Fast 2-point correlation estimation with LSDB and gundam

BSD 3-Clause "New" or "Revised" License

2 stars 1 forks source link

Compute angular correlation with weights #12

Closed camposandro closed 3 months ago

camposandro commented 3 months ago

Updates the angular correlation to compute estimates with weighted catalogs. To enable this, cff.mod.th_A_wg_naiveway and cff.mod.th_C_wg_naiveway were introduced in Gundam.

[ ] My PR includes a link to the issue that I am addressing

Code Quality

[X] I have read the Contribution Guide
[X] My code follows the code style of this project
[X] My code builds (or compiles) cleanly without any errors or warnings
[X] My code contains relevant comments and necessary documentation

github-actions[bot] commented 3 months ago

Before [1ff1f9d9]	After [4931bb9a]	Ratio	Benchmark (Parameter)
3.81±0.8s	2.12±1s	~0.56	benchmarks.time_computation
336	1.66k	4.95	benchmarks.mem_list

Click here to view all benchmarks.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files	Coverage Δ
src/corrgi/correlation/angular_correlation.py	`100.00% <100.00%> (ø)`
src/corrgi/correlation/correlation.py	`88.57% <100.00%> (+0.33%)`	:arrow_up:
src/corrgi/corrgi.py	`93.33% <100.00%> (+1.02%)`	:arrow_up:
src/corrgi/dask.py	`77.77% <100.00%> (ø)`