Initial implementation of "cone optimization" constraint.

lincc-frameworks-mask-incubator / corrgi

Fast 2-point correlation estimation with LSDB and gundam

BSD 3-Clause "New" or "Revised" License

2 stars 1 forks source link

Initial implementation of "cone optimization" constraint. #28

Open delucchi-cmu opened 1 month ago

delucchi-cmu commented 1 month ago

Change Description

Simple implementation of the "cone optimization" constraint that drops partition pairs if we believe there will be no pair counts between any particles in the two partitions.

Only implemented for auto-correlation pair finding at first.

github-actions[bot] commented 1 month ago

Before [b18cc976]	After [7a856b26]	Ratio	Benchmark (Parameter)
2.00±1s	2.06±0.9s	1.03	benchmarks.time_computation
3.41k	2.3k	0.68	benchmarks.mem_list

Click here to view all benchmarks.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Files	Coverage Δ
src/corrgi/dask.py	`85.00% <100.00%> (+12.02%)`	:arrow_up:
src/corrgi/alignment.py	`97.67% <96.96%> (-2.33%)`	:arrow_down:

... and 5 files with indirect coverage changes