This pull request consolidates the code quality checks, removing the dedicated code style analysis pipeline and using pre-commit to handle the checks both locally and on the CI. Closes #410.
[X] Removes the code_style.yml.jinja script
[X] Adjusts pre-commit.ci to run over all files, not just changed files
[X] Adjusts pre-commit.ci to disable fail-fast so all code style issues are surfaced at once
[X] Makes the unit test hook run last because it's the most expensive
If configured, a bot will push automatic fixes to non-draft PRs to apply code formatting, ordering of imports and clear notebook outputs, if there are any (example). Most linting issues need to be addressed manually by the user.
Checklist
[X] This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
[X] This change is linked to an open issue
[X] This change includes integration testing, or is small enough to be covered by existing tests
This pull request consolidates the code quality checks, removing the dedicated code style analysis pipeline and using pre-commit to handle the checks both locally and on the CI. Closes #410.
code_style.yml.jinjascriptpre-commit.cito run over all files, not just changed filespre-commit.cito disable fail-fast so all code style issues are surfaced at onceIf configured, a bot will push automatic fixes to non-draft PRs to apply code formatting, ordering of imports and clear notebook outputs, if there are any (example). Most linting issues need to be addressed manually by the user.
Checklist
lincc-frameworks/python-project-templaterepo and not a downstream one instead.