lincc-frameworks / tape

[Deprecated] Package for working with LSST time series data
https://tape.readthedocs.io
MIT License
12 stars 3 forks source link

Loaders for LSDB and hipscat (reimplementation using LSDB) data #374

Closed dougbrn closed 8 months ago

dougbrn commented 9 months ago

Change Description

Resolves #360. Adds an Ensemble loader function for LSDB catalog objects. Reimplements Ensemble.from_hipscat to use LSDB under the hood. Adds a new tutorial to the docs, potentially addressing #367

Solution Description

The main implementation for both functions is fairly straightforward, just piping the LSDB catalog dataframes into Ensemble.from_dask_dataframe. There's a few things that contributed to API/implementation complexity:

Code Quality

Project-Specific Pull Request Checklists

Bug Fix Checklist

New Feature Checklist

Documentation Change Checklist

Build/CI Change Checklist

Other Change Checklist

github-actions[bot] commented 9 months ago
Before [65d1fbfa] After [63b48a6f] Ratio Benchmark (Parameter)
41.6±0.1ms 42.8±0.3ms 1.03 benchmarks.time_prune_sync_workflow
39.5±0.2ms 40.1±0.2ms 1.02 benchmarks.time_batch

Click here to view all benchmarks.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (65d1fbf) 95.27% compared to head (f26917d) 95.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #374 +/- ## ========================================== + Coverage 95.27% 95.40% +0.13% ========================================== Files 25 25 Lines 1671 1698 +27 ========================================== + Hits 1592 1620 +28 + Misses 79 78 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

review-notebook-app[bot] commented 8 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB