search

lincc-frameworks / tape

[Deprecated] Package for working with LSST time series data
https://tape.readthedocs.io
MIT License
12 stars 3 forks source link

Pin Dask dependency to avoid dask-expr #387

Closed wilsonbb closed 6 months ago

wilsonbb commented 6 months ago

As noted in https://github.com/lincc-frameworks/tape/issues/382, we currently do not support dask-expr as a backend, however it became the default Dask backend with the release of Dask 2024.3.0 (See https://github.com/dask/community/issues/366)

Here we pin Dask to be in a range below this version until dask-expr support is fully added.

Additionally in the LSDB notebook, we update the cone_search call to use the new radius_arcsec argument (formerly just radius)

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions[bot] commented 6 months ago
Before [f740b6f4] <v0.3.4> After [801b9eaa] Ratio Benchmark (Parameter)
59.1±7ms 47.4±0.5ms ~0.80 benchmarks.time_batch
49.5±0.7ms 51.0±1ms 1.03 benchmarks.time_prune_sync_workflow

Click here to view all benchmarks.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.53%. Comparing base (f740b6f) to head (5ad5c21).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #387 +/- ## ======================================= Coverage 95.53% 95.53% ======================================= Files 25 25 Lines 1702 1702 ======================================= Hits 1626 1626 Misses 76 76 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.