lincc-frameworks / tape

[Deprecated] Package for working with LSST time series data
https://tape.readthedocs.io
MIT License
12 stars 3 forks source link

Load pre-sorted datasets in documentation notebooks #397

Closed wilsonbb closed 5 months ago

wilsonbb commented 5 months ago

In our TAPE documentation notebooks, we encounter warnings when loading datasets where divisions are not set.

Screenshot 2024-03-14 at 3 01 46 PM

We can ensure that the Ensemble has divisions and avoids those warnings by using sorted=True for pre-sorted data or sort=True for unsorted data.

To avoid having to sort data in our tutorial notebooks, we can pre-sort our datasets (like s82_rrlyrae which is currently unsorted) and then use the sorted=True flag

dougbrn commented 5 months ago

I went about this a slightly different way, by having the from_dataset function sort them as part of the ingest function. I think we can close this as a result, and with #415.