lincc-frameworks / tape

[Deprecated] Package for working with LSST time series data
https://tape.readthedocs.io
MIT License
12 stars 3 forks source link

Simplify "Working with the Ensemble" Notebook #401

Closed wilsonbb closed 5 months ago

wilsonbb commented 5 months ago

Change Description

Finishes addressing https://github.com/lincc-frameworks/tape/issues/392 simplifying the "Working with the Ensemble" notebook to focus on how the Ensemble manages and syncs its dataframes.

This simplification is allowed by the addition of a common operations tutorial added by @dougbrn in https://github.com/lincc-frameworks/tape/pull/395

In addition toe light_curve package example was added to the batch showcase notebook.

review-notebook-app[bot] commented 5 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 5 months ago
Before [0448c67c] After [dc0e6fc5] Ratio Benchmark (Parameter)
45.3±0.7ms 44.9±0.3ms 0.99 benchmarks.time_batch
47.6±0.2ms 47.3±0.4ms 0.99 benchmarks.time_prune_sync_workflow

Click here to view all benchmarks.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.53%. Comparing base (0448c67) to head (72692c6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #401 +/- ## ======================================= Coverage 95.53% 95.53% ======================================= Files 25 25 Lines 1702 1702 ======================================= Hits 1626 1626 Misses 76 76 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wilsonbb commented 5 months ago

This looks good, as we've discussed adding 1 or 2 diagrams could really help here as well.

This was a good suggestion, and I've added two diagrams and altered some phrasing.

dougbrn commented 5 months ago

Thanks for adding the diagrams @wilsonbb , it looks like they're off-center in the readthedocs rendering just fyi