lincc-frameworks / tape

[Deprecated] Package for working with LSST time series data
https://tape.readthedocs.io
MIT License
12 stars 3 forks source link

Add support for running batch on a single lightcurve #420

Closed wilsonbb closed 5 months ago

wilsonbb commented 5 months ago

Change Description

In https://github.com/lincc-frameworks/tape/issues/409 it was proposed to add a batch helper function try_batch which would allow Ensemble.batch to be tested on a single lightcurve. To accomplish that goal, here we instead add a new parameter single_lc to Ensemble.batch

When single_lc is provided an object ID, the function provided to batch is executed on that single lightcurve.

Code Quality

New Feature Checklist

review-notebook-app[bot] commented 5 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 5 months ago
Before [d72d1e7f] After [cad54cd2] Ratio Benchmark (Parameter)
36.6±1ms 36.7±0.3ms 1 benchmarks.time_prune_sync_workflow
36.6±0.9ms 35.6±0.6ms 0.97 benchmarks.time_batch

Click here to view all benchmarks.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.84%. Comparing base (d72d1e7) to head (c454bba).

Files Patch % Lines
src/tape/ensemble.py 89.47% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #420 +/- ## ========================================== + Coverage 95.82% 95.84% +0.02% ========================================== Files 25 25 Lines 1771 1781 +10 ========================================== + Hits 1697 1707 +10 Misses 74 74 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.