lincc-frameworks / tape

[Deprecated] Package for working with LSST time series data
https://tape.readthedocs.io
MIT License
12 stars 3 forks source link

remove slow timing comparsion #425

Closed dougbrn closed 5 months ago

dougbrn commented 5 months ago

The timing comparison takes >5 minutes to build here, making it a disproportionate amount of the doc build time. We've seen timing to be more workflow dependent, so it seems best to just have users test ray if it's interesting to them and let them see the results for themselves.

review-notebook-app[bot] commented 5 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 5 months ago
Before [bac4fe73] After [7d241f69] Ratio Benchmark (Parameter)
32.7±0.5ms 32.9±0.2ms 1.01 benchmarks.time_batch
33.7±0.4ms 34.1±0.2ms 1.01 benchmarks.time_prune_sync_workflow

Click here to view all benchmarks.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.78%. Comparing base (bac4fe7) to head (febcac6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #425 +/- ## ======================================= Coverage 95.78% 95.78% ======================================= Files 25 25 Lines 1755 1755 ======================================= Hits 1681 1681 Misses 74 74 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.