lincc-frameworks / tdastro

MIT License
4 stars 0 forks source link

Remove the EffectModel class #126

Closed jeremykubica closed 1 month ago

jeremykubica commented 1 month ago

Instead of having a arbitrary list of effects for the parameterized node, we are going to support a few productionized effects directly in parts of the code such as PhysicalModel. This will reduce complexity of the code and make it more difficult to make ordering errors.

github-actions[bot] commented 1 month ago
Before [7450fcce] After [cb21dbfc] Ratio Benchmark (Parameter)
1.20±0.02s 1.21±0.02s 1.01 benchmarks.time_x1_from_hostmass
7.09±0.02ms 7.04±0.04ms 0.99 benchmarks.time_chained_evaluate

Click here to view all benchmarks.