search

lincc-frameworks / tdastro

MIT License
4 stars 0 forks source link

Create a proof of concept JAX implementation of SALT2 #130

Closed jeremykubica closed 1 month ago

jeremykubica commented 1 month ago

This is a minimal implementation of SALT2 using JAX. It is currently a lot slower than the sncosmo version (and can likely be optimized), but produces the correct results.

The PR includes a JAX version of sncosmo's bicubic interpolator (again this is slower than the cython version).

github-actions[bot] commented 1 month ago
Before [7450fcce] After [22c74f12] Ratio Benchmark (Parameter)
7.05±0.04ms 7.00±0.02ms 0.99 benchmarks.time_chained_evaluate
1.25±0.01s 1.24±0.01s 0.99 benchmarks.time_x1_from_hostmass

Click here to view all benchmarks.

jeremykubica commented 1 month ago

Closing because we don't need this at the moment.