Refactor SN Ia e2e test to use oversampled opsim

[hombit]

This is a part of work to incorporate noise generation into the simulation pipeline started in #108

The changes:

1. Introduces oversampled_observations fixture
2. Changes the interface of test_snia_end2end and helper test function draw_single_random_sn to use opsim only, removes phases calculations
3. This new changes revealed some inconsistency between band fluxes we produce and sncosmo produces. I changed passbands we use from ur to ri and model from SALT2 to SALT3. I opened an issue about this inconsistency https://github.com/lincc-frameworks/tdastro/issues/133
4. I fix some broken NB code and modified NB to use the new test interface. I opened issue https://github.com/lincc-frameworks/tdastro/issues/131 to run notebooks on CI.
5. Since NB called the test functions (I believe it was not the best idea), it also needs to access some pytest fixtures. I introduced an ugly hack in conftest.py to fix it. I hope someone would volunteer to fix it in a proper way.

Change Description

• [ ] My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

• [ ] I have read the Contribution Guide
• [ ] My code follows the code style of this project
• [ ] My code builds (or compiles) cleanly without any errors or warnings
• [ ] My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

• [ ] My fix includes a new test that breaks as a result of the bug (if possible)
• [ ] My change includes a breaking change
  • [ ] My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

• [ ] I have added or updated the docstrings associated with my feature using the NumPy docstring format
• [ ] I have updated the tutorial to highlight my new feature (if appropriate)
• [ ] I have added unit/End-to-End (E2E) test cases to cover my new feature
• [ ] My change includes a breaking change
  • [ ] My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

• [ ] Any updated docstrings use the NumPy docstring format

Build/CI Change Checklist

• [ ] If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
• [ ] If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

• [ ] Any new or updated docstrings use the NumPy docstring format.
• [ ] I have updated the tutorial to highlight my new feature (if appropriate)
• [ ] I have added unit/End-to-End (E2E) test cases to cover any changes
• [ ] My change includes a breaking change
  • [ ] My change includes backwards compatibility and deprecation warnings (if possible)

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB