lincc-frameworks / tdastro

MIT License
4 stars 0 forks source link

Inconsistency in SN Ia utility functions return values #134

Closed hombit closed 1 month ago

hombit commented 1 month ago

Bug report

Some of SN Ia utility functions return float, while some others return a single-element 1-d array. So in the SN Ia end2end test, source.get_param(state, parname) returns float for parname "t0", "c", "redshift", "ra", "dec" and single-element 1-d array for "x1", "x2". https://github.com/lincc-frameworks/tdastro/blob/bcd50785bc63527bc8769a51f4eff17e0701f051/tests/tdastro/sources/test_snia.py#L167

Before submitting Please check the following: