Change sncosmo output flux unit to fnu

lincc-frameworks / tdastro

MIT License

4 stars 0 forks source link

Closed mi-dai closed 1 month ago

mi-dai commented 1 month ago

A few things are changed in this PR

sncosmo model now return flux in f_nu units
flux calculation in redshift effect was changed and now f_nu_obs = f_nu_rest * (1+z)
apply_reshift and obs_frame_to_rest_frame are renamed to rest_to_obs_flux and obs_to_rest_times_waves for clarity.
added a bit more documentation to explain the flux conversion to PhysicalModel._evaluate()

github-actions[bot] commented 1 month ago

Before [7efe1be2]	After [2c73242b]	Ratio	Benchmark (Parameter)
7.04±0.03ms	7.10±0.05ms	1.01	benchmarks.time_chained_evaluate
1.42±0.01s	1.41±0.01s	0.99	benchmarks.time_x1_from_hostmass

Click here to view all benchmarks.