Closed mtauraso closed 2 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Before [9fcdf6dd] | After [0441ab9e] | Ratio | Benchmark (Parameter) |
---|---|---|---|
6.92±0.05ms | 6.86±0.03ms | 0.99 | benchmarks.time_chained_evaluate |
Click here to view all benchmarks.
Looks good, thanks for adding this.
Let's discuss docstring style next Tues--no strong personal opinions, and I do really like how explicit the
units
parameter is here, but would be nice to codify something before we diverge too much.
I was a bit worried when I added that part... Not sure if it really even needs to be there, because I don't know much about what sorts of passband files tdastro needs to support.
I considered astropy.units for this part, but it seemed like too much complexity just to get the piece of code working again after I broke it by introducing the LSST passband file from github for seemingly the first time.
Planning to Merge sometime Tuesday (9/3) unless someone asks me not to.
git status
doesn't report untracked files.