search

lincc-frameworks / tdastro

MIT License
4 stars 0 forks source link

Update the small opsim db #99

Closed jeremykubica closed 2 months ago

jeremykubica commented 2 months ago

Closes #98

Update the opsim test data to match the columns in the Rubin data. In order to generate the new data without information like AirMass, we need to make adding the zero points optional. This PR changes zero point addition from happening automatically in the constructor to being a manual call of add_zero_points().

github-actions[bot] commented 2 months ago
Before [1b2bc95c] After [0450a912] Ratio Benchmark (Parameter)
7.03±0.4ms 7.35±0.2ms 1.05 benchmarks.time_chained_evaluate
1.20±0.03s 1.22±0.02s 1.01 benchmarks.time_x1_from_hostmass

Click here to view all benchmarks.

hombit commented 2 months ago

I'll make a PR for this PR after (conflicting) #97 merged