search

lincheney / fzf-tab-completion

Tab completion using fzf
GNU General Public License v3.0
600 stars 39 forks source link

Issue with `fast-syntax-highlighting` #72

Open musjj opened 1 year ago

musjj commented 1 year ago

With fast-syntax-highlighting, the syntax highlighting for the argument will be gone after you complete it and it won't return until you press another key:

https://github.com/lincheney/fzf-tab-completion/assets/72612857/2908866b-b046-48f3-9329-51675c2ebaae

musjj commented 1 year ago

Fixed by loading the plugin before fast-syntax-highlighting. Adding this to the readme would probably be helpful.

lincheney commented 1 year ago

Yeah I can do that. I've never used fast-syntax-highlighting, but tbh flicking through their code, the plugin ordering looks like its a requirement of fast-syntax-highlighting not fzf-tab-completion given how they are modifying other widgets, so I'm surprised it's not documented in their installation process. I would expect anything that creates zsh widgets to run into this same problem as a result. https://github.com/zdharma-continuum/fast-syntax-highlighting/blob/13d7b4e63468307b6dcb2dadf6150818f242cbff/fast-syntax-highlighting.plugin.zsh#L227

musjj commented 2 months ago

Tbh, I'm still having problems with this. When pressing Esc to close the fzf prompt, the syntax highlighting disappears. Do you have any idea what's causing this? This isn't a problem with the default fzf integration (Ctrl+T, Ctrl+R, etc.).