search

lincheney / fzf-tab-completion

Tab completion using fzf
GNU General Public License v3.0
623 stars 40 forks source link

Regression with bash keywords #90

Closed przepompownia closed 6 months ago

przepompownia commented 7 months ago

With the current master I get the same bug as in https://github.com/lincheney/fzf-tab-completion/issues/67 Bisection suggests that

test@del:~/.src/external/fzf-tab-completion$ git bisect good
9616591b74c72c0f716b214c659b2c3c91964e75 is the first bad commit
commit 9616591b74c72c0f716b214c659b2c3c91964e75
Author: 林千里 <lincheney@gmail.com>
Date:   Mon Jan 22 23:40:10 2024 +1100

    bash: remove \x00 to make it work better on mac?

 bash/fzf-bash-completion.sh | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

so at the moment I need to check out to the previous commit.

lincheney commented 7 months ago

:( I might just revert this and advice mac users to use gsed instead

lincheney commented 6 months ago

:( I might just revert this and advice mac users to use gsed instead

Done

przepompownia commented 6 months ago

Thanks!