Change penalty rules. Small optimization. Add optional argument mask_pattern.

lincolnloop / python-qrcode

Python QR Code image generator

https://pypi.python.org/pypi/qrcode

Other

4.36k stars 667 forks source link

Change penalty rules. Small optimization. Add optional argument mask_pattern. #127

Closed cryptogun closed 6 years ago

cryptogun commented 7 years ago

Fixes #125 . Fixes #126 .

SmileyChris commented 7 years ago

Nice work! I'll take a closer review of this early next year and we can roll out a release then :)

SmileyChris commented 6 years ago

Thanks @cryptogun for your work here. Apologies for how long it took to get merged :sleeping:

cryptogun commented 6 years ago

@SmileyChris you're welcome~ I'm busy doing other things too. P.S: Maybe you should remove the last commit (i.e. pip install ... from my own GitHub url). (Seems that you've done so.)

SmileyChris commented 6 years ago

Yeah, I did it as part of the merge commit. Thanks again!