`ECF_AUTO_SVC_LEVEL_DISABLED` not set when `AUTOSVCLEVEL` is not defined

lincomatic / open_evse

Firmware for Open EVSE

GNU General Public License v3.0

116 stars 166 forks source link

`ECF_AUTO_SVC_LEVEL_DISABLED` not set when `AUTOSVCLEVEL` is not defined #148

Closed jeremypoulter closed 2 years ago

jeremypoulter commented 2 years ago

When AUTOSVCLEVEL is disabled (as it is in the EU versions of the firmware) the ECF_AUTO_SVC_LEVEL_DISABLED flag is not set so the WiFi controller thinks the controller is in auto mode, no matter what is sent via $SL.

lincomatic commented 2 years ago

I had assumed that builds w/ AUTOSVCLEVEL disabled wouldn't need to test the flag, since it's not an option to enable it. You could just disable the flag with a build that has AUTOSVCLEVEL enabled, save the EEPROM, and burn that saved file into units that need the flag set. Anyway, it was just a 1-line change. https://github.com/lincomatic/open_evse/commit/d9ec7fed68c9ae7fa18d15663d943bb1d5d0d59c

jeremypoulter commented 2 years ago

Thanks, there is not a separate build of the WiFi firmware for US/EU so it has no knowledge of the features enabled in the firmware.