search

lincomatic / open_evse

Firmware for Open EVSE
GNU General Public License v3.0
114 stars 163 forks source link

On over-temperature alarm, only set backlight when needed #50

Closed presslab-us closed 8 years ago

presslab-us commented 8 years ago

With previous code it is not possible to turn off the backlight over RAPI while charging.

Tested using TESTING_TEMPERATURE_OPERATION and flashing backlight worked as expected.

lincomatic commented 8 years ago

Thank you for the pull request. I'm waiting for CraigK to review it, as he is the author of the overtemperature code. In the future, please submit pull requests only to the development branch, as the stable branch is only for promoted code from the development branch.

presslab-us commented 8 years ago

I wasn't sure about that because development is some commits behind stable. Would you like me to rebase this on the development branch?

craigk46 commented 8 years ago

Sam, I'm away from home with little ability to review it and test anything until Sunday 10th. I can look at it then. Pardon the big delay.

Best Wishes, Craig Kirkpatrick 971-770-8140

On Jan 5, 2016, at 10:18 PM, lincomatic notifications@github.com wrote:

Thank you for the pull request. I'm waiting for CraigK to review it, as he is the author of the overtemperature code. In the future, please submit pull requests only to the development branch, as the stable branch is only for promoted code from the development branch.

— Reply to this email directly or view it on GitHub.

presslab-us commented 8 years ago

@craigk46 did you have a chance to look at this? Thanks!

presslab-us commented 8 years ago

New pull request based on development branch here: https://github.com/lincomatic/open_evse/pull/57