Closed Mike4U closed 8 years ago
Redid this to the development branch. Sorry to be learning Github on your project.
Sorry for taking forever to review this... I was hoping CraigK would look at it, because I don't really use the kW tracking stuff, and don't know how it behaves. However, he seems to be MIA.
Unfortunately, your changes are applied to an old version of the code, so I can't merge it. Looking at the current code in the dev branch, it appears that maybe the latest code already behaves the way you want, as far as only clearing kwsecs when entering STATE A. However, g_WattSeconds when enter Sleep() (and thus, when you enter the menus)... I agree with you that it shouldn't be zeroed there, so I am going to push a change get rid of that.
Thanks again for your help.
Hi, Hope CraigK is not really MIA. The last web person I was developing software with, known to me only as ’solder’ died of a heart attack at only 35. I found out about it by luck after trying to contact him for about a month. Downside of web development.
later
On Apr 12, 2016, at 4:42 PM, lincomatic notifications@github.com wrote:
Sorry for taking forever to review this... I was hoping CraigK would look at it, because I don't really use the kW tracking stuff, and don't know how it behaves. However, he seems to be MIA.
Unfortunately, your changes are applied to an old version of the code, so I can't merge it. Looking at the current code in the dev branch, it appears that maybe the latest code already behaves the way you want, as far as only clearing kwsecs when entering STATE A. However, g_WattSeconds when enter Sleep() (and thus, when you enter the menus)... I agree with you that it shouldn't be zeroed there, so I am going to push a change get rid of that.
Thanks again for your help.
— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub
only when state changes from A to B i.e. from unconnected to connected.
Clear g_WattSeconds only after adding to g_WattHours_accumulated and only when state changes from A to B i.e. from unconnected to connected.
The reasoning?